Fix Bug in Academy: Not remembering scroll position. #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
force-pushed
the
LD-203-history-state
branch
4 times, most recently
from
025a896
to
6c3a182
Compare
This completely refactors how the header, sidebar, main content, and table of contents (TOC) are laid out. Previously, JS was required to keep track of the scroll position on reload. This caused bugs (like the wrong position being restored on reload if you clicked a link in the TOC) and led to some features being lost (like the “tap to scroll to the top of the page” in Safari). Now, the browser is able to keep track of the scroll position for the page, so no JS is required and the CSS layout is more robust.
chasenlehara
force-pushed
the
LD-203-history-state
branch
from
6c3a182
to
bf6dd87
Compare
chasenlehara
added a commit
that referenced
this pull request
Aug 16, 2024
This reverts commit bcd2bba. Looks like there’s a bug when loading a URL with a fragment in it (the page does not automatically scroll down).
chasenlehara
added a commit
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.history.state was null thus the eventListener on scroll couldn't finish running, added push state after checking hash so that it should always have a value on load